Updated clean_strain() to return spike model when return_mcmcs is tru…#1
Updated clean_strain() to return spike model when return_mcmcs is tru…#1HarrisonS-Phys wants to merge 1 commit intofarr:mainfrom
Conversation
…e, and removed extraneous lines of code
|
I'm curious about the return values here---why don't you return the time-domain line model instead of the real and imag freq components? (Just thinking about Fourier transform conventions---everything input to the cleaner is real, and if everything output from the cleaner is also real, then we don't have to fuss about definitions of FTs, because it's all internal; as well, it's easier to understand the time-domain line model, no?) Also: why are you just returning the real part of the data frequency series? Sort of the same question? |
|
Also, also: isn't there an extra |
|
Finally, finally (I hope): note that you can extract the frequency components of the line model already from the predicted samples---so maybe it would be better just to store the td line model in the prediction instead of returning separately? |
…e, and removed extraneous lines of code